<html>
<head><meta charset="utf-8"><title>Clippy tests and PR CI · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html">Clippy tests and PR CI</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="210660476"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Clippy%20tests%20and%20PR%20CI/near/210660476" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html#210660476">(Sep 20 2020 at 10:46)</a>:</h4>
<p>Is it expected that clippy tests do not run for PR CI? <a href="https://github.com/rust-lang/rust/pull/76136">https://github.com/rust-lang/rust/pull/76136</a> broke Clippy but we only realized when a rollup failed (and same for a similar other PR).</p>



<a name="210664832"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Clippy%20tests%20and%20PR%20CI/near/210664832" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html#210664832">(Sep 20 2020 at 12:30)</a>:</h4>
<p>in general PR CI doesn't run as much as <code>@bors try</code> or a full build</p>



<a name="210664850"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Clippy%20tests%20and%20PR%20CI/near/210664850" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html#210664850">(Sep 20 2020 at 12:30)</a>:</h4>
<p>not sure whether ignoring clippy in PRs was intentional or not though</p>



<a name="210667331"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Clippy%20tests%20and%20PR%20CI/near/210667331" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html#210667331">(Sep 20 2020 at 13:33)</a>:</h4>
<p>we only used to check tools in pre-merge ci if the PR changed one of the submodules iirc, which worked fine until clippy became a subrepo and we started gating on it.<br>
It's probably not intentional, just outdated</p>



<a name="210667805"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Clippy%20tests%20and%20PR%20CI/near/210667805" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html#210667805">(Sep 20 2020 at 13:47)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI/near/210664832">said</a>:</p>
<blockquote>
<p>in general PR CI doesn't run as much as <code>@bors try</code> or a full build</p>
</blockquote>
<p>AFAIK <code>bors try</code>doesnt even run any tests. it just prepares a toolchain for use by crater/perf/manual inspection</p>



<a name="210667846"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Clippy%20tests%20and%20PR%20CI/near/210667846" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html#210667846">(Sep 20 2020 at 13:48)</a>:</h4>
<p><span class="user-mention silent" data-user-id="217864">matthiaskrgr</span> <a href="#narrow/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI/near/210667331">said</a>:</p>
<blockquote>
<p>we only used to check tools in pre-merge ci if the PR changed one of the submodules iirc, which worked fine until clippy became a subrepo and we started gating on it.<br>
It's probably not intentional, just outdated</p>
</blockquote>
<p>yeah that's what I thought, hence me bringing this up</p>



<a name="210667924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Clippy%20tests%20and%20PR%20CI/near/210667924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html#210667924">(Sep 20 2020 at 13:51)</a>:</h4>
<blockquote>
<p>AFAIK bors trydoesnt even run any tests. it just prepares a toolchain for use by crater/perf/manual inspection</p>
</blockquote>
<p>bors try does run the testsuite, but afaik not the entire one and not on all targets just a few.</p>



<a name="210671505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Clippy%20tests%20and%20PR%20CI/near/210671505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html#210671505">(Sep 20 2020 at 15:27)</a>:</h4>
<p>bors try runs <em>no</em> tests</p>



<a name="210671509"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Clippy%20tests%20and%20PR%20CI/near/210671509" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html#210671509">(Sep 20 2020 at 15:27)</a>:</h4>
<p>it literally only runs a dist build, which doesn't even compile tests</p>



<a name="210671519"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Clippy%20tests%20and%20PR%20CI/near/210671519" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html#210671519">(Sep 20 2020 at 15:28)</a>:</h4>
<p>the PR builder should run a pretty complete suite of tests, and it sounds like a bug if that's not covering clippy tests</p>



<a name="210671552"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Clippy%20tests%20and%20PR%20CI/near/210671552" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html#210671552">(Sep 20 2020 at 15:28)</a>:</h4>
<p>(please file an issue and cc me)</p>



<a name="210708511"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Clippy%20tests%20and%20PR%20CI/near/210708511" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI.html#210708511">(Sep 21 2020 at 07:27)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/242791-t-infra/topic/Clippy.20tests.20and.20PR.20CI/near/210671552">said</a>:</p>
<blockquote>
<p>(please file an issue and cc me)</p>
</blockquote>
<p>done: <a href="https://github.com/rust-lang/rust/issues/76999">https://github.com/rust-lang/rust/issues/76999</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>